Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update svar access documentation. #2790

Merged
merged 4 commits into from
May 13, 2024
Merged

docs: Update svar access documentation. #2790

merged 4 commits into from
May 13, 2024

Conversation

prmukherj
Copy link
Collaborator

No description provided.

@prmukherj prmukherj changed the title doc: Update svar access documentation. docs: Update svar access documentation. May 7, 2024
raph-luc
raph-luc reviewed May 7, 2024
View reviewed changes
Copy link
Member

@raph-luc raph-luc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is #2784 the issue that should be linked to this PR?

@prmukherj prmukherj linked an issue May 7, 2024 that may be closed by this pull request
When I try to retrieve data using ‘solver_session. solution_variable_info’ and ‘solver_session. solution_variable_data’, it prompts' has no attribute 'solution_variable_info' #2784
Closed
2 tasks
raph-luc
raph-luc reviewed May 7, 2024
View reviewed changes
Copy link
Member

@raph-luc raph-luc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should doc/source/user_guide/index.rst also be updated from solver.field_data to solver.fields.field_data?

@prmukherj
Copy link
Collaborator Author

Should doc/source/user_guide/index.rst also be updated from solver.field_data to solver.fields.field_data?

Yes, Thank you @raph-luc.

@prmukherj prmukherj enabled auto-merge (squash) May 8, 2024 04:15
@prmukherj prmukherj merged commit 64d3302 into release/0.20 May 13, 2024
26 checks passed
@prmukherj prmukherj deleted the doc/update_svar_doc branch May 13, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpearsonuk seanpearsonuk seanpearsonuk approved these changes

@mkundu1 mkundu1 mkundu1 approved these changes

@hpohekar hpohekar hpohekar approved these changes

@raph-luc raph-luc raph-luc approved these changes

@ajain-work ajain-work Awaiting requested review from ajain-work ajain-work is a code owner

@dnwillia-work dnwillia-work Awaiting requested review from dnwillia-work dnwillia-work is a code owner

@h-krishnan h-krishnan Awaiting requested review from h-krishnan h-krishnan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@prmukherj @seanpearsonuk @mkundu1 @hpohekar @raph-luc