refactor: Remove 'show_gui' from launch_fluent arguments. #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prmukherj
requested review from
mkundu1,
seanpearsonuk,
ajain-work,
dnwillia-work,
hpohekar,
h-krishnan and
raph-luc
as code owners
prmukherj
commented
May 9, 2024
mkundu1
reviewed
May 9, 2024
mkundu1
approved these changes
May 9, 2024
hpohekar
approved these changes
May 9, 2024
Co-authored-by: Sean Pearson <93727996+seanpearsonuk@users.noreply.github.com>
Co-authored-by: Sean Pearson <93727996+seanpearsonuk@users.noreply.github.com>
raph-luc
reviewed
May 9, 2024
Co-authored-by: Raphael Luciano <raphael.luciano@ansys.com>
Co-authored-by: Raphael Luciano <raphael.luciano@ansys.com>
Co-authored-by: Raphael Luciano <raphael.luciano@ansys.com>
for more information, see https://pre-commit.ci
seanpearsonuk
approved these changes
May 9, 2024
raph-luc
approved these changes
May 9, 2024
| argument.""" | ||
| if old_arg in kwargs: | ||
| warnings.warn( | ||
| f"'{old_arg}' is deprecated. Use '{new_arg}' instead.", |
There was a problem hiding this comment.
At this point we will be automatically replacing the deprecated argument with the new one, right? So I think a more appropriate wording would be:
Suggested change
| f"'{old_arg}' is deprecated. Use '{new_arg}' instead.", | |
| f"'{old_arg}' is deprecated. Using '{new_arg}' instead.", |
And can we move val definition before this warning, so that we can show it in the warning as well to better inform the user?
For example, putting these two suggestions together:
Suggested change
| f"'{old_arg}' is deprecated. Use '{new_arg}' instead.", | |
| f"'{old_arg}' is deprecated. Using '{new_arg} = {val}' instead.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the ''show_gui'' argument and put a mechanism for migrating older scripts.