-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Prepare codegen to run with Fluent #2806
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
changed the title
feat: codegen from static_infos
feat: Prepare codegen to run with Fluent
May 11, 2024
mkundu1
commented
May 11, 2024
mkundu1
commented
May 11, 2024
mkundu1
commented
May 11, 2024
mkundu1
requested review from
seanpearsonuk,
ajain-work,
dnwillia-work,
prmukherj,
hpohekar,
h-krishnan and
raph-luc
as code owners
May 11, 2024 06:40
prmukherj
approved these changes
May 12, 2024
seanpearsonuk
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CODEGEN_OUTDIR
controls where API files are written out during codegen. In Fluent, this path is set to some path within Fluent package.CODEGEN_ZIP_SETTINGS
controls whether to zip the settings API files. This is to reduce number of files during Fluent packaging.Draft Fluent PR - 491855