fix: launcher additional arguments #2807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raph-luc
requested review from
mkundu1,
seanpearsonuk,
ajain-work,
dnwillia-work,
prmukherj,
hpohekar and
h-krishnan
as code owners
seanpearsonuk
approved these changes
May 13, 2024
|
@raph-luc many thanks. Please could you go over this in the next meeting. In particular, please cover issues such as Thanks. |
hpohekar
approved these changes
May 13, 2024
prmukherj
approved these changes
May 13, 2024
mkundu1
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additional_argumentswas being evaluated in two different places:_build_fluent_launch_args_stringand_generate_launch_string, and wasn't being passed properly to the container launcheradditional_argumentsis also repeated insideself.argvalsandself.additional_argumentsin the launchers, not sure why, not changed in this PRThe suggestion in this PR is to evaluate
additional_argumentsonly in_build_fluent_launch_args_string, so that it is also applicable to container launchers and not only launchers that call_generate_launch_string(slurm and standalone launchers currently)