test: Add a test for System Coupling related settings

[ochernuk]

Adding a simple test to check System Coupling related settings. It's probably worth adding a few more, but that can be done separately.

[ochernuk]

@seanpearsonuk @mkundu1 @raph-luc wondering if you could offer any insight here. The test that I added is failing using v24.2.0 Fluent. Looks like it comes down to not being able to download the SCP file that Fluent generates from the container. So, either it's not using the download functionality correctly here:

pyfluent/src/ansys/fluent/core/systemcoupling.py

Line 92 in dcb2f69

# download the file locally in case Fluent is in a container

... or the download() function is not working on GitHub.

(the assert on line 96 in the above link fails)

[raph-luc]

@ochernuk You're right, and it's failing in v241 too not only v242. We definitely need some tests specifically for the File Transfer Service-related methods to give us confidence that it is working properly, I will make sure we bring this up in the team meeting tomorrow if others don't get to this first.

[seanpearsonuk]

@seanpearsonuk @mkundu1 @raph-luc wondering if you could offer any insight here. The test that I added is failing using v24.2.0 Fluent. Looks like it comes down to not being able to download the SCP file that Fluent generates from the container. So, either it's not using the download functionality correctly here:

pyfluent/src/ansys/fluent/core/systemcoupling.py

Line 92 in dcb2f69

# download the file locally in case Fluent is in a container

... or the download() function is not working on GitHub.

(the assert on line 96 in the above link fails)

@hpohekar Is it expected to work? Do we have relevant tests?

[hpohekar]

@seanpearsonuk @mkundu1 @raph-luc wondering if you could offer any insight here. The test that I added is failing using v24.2.0 Fluent. Looks like it comes down to not being able to download the SCP file that Fluent generates from the container. So, either it's not using the download functionality correctly here:

pyfluent/src/ansys/fluent/core/systemcoupling.py

Line 92 in dcb2f69

# download the file locally in case Fluent is in a container

... or the download() function is not working on GitHub.
(the assert on line 96 in the above link fails)

@hpohekar Is it expected to work? Do we have relevant tests?

@seanpearsonuk We are not using any file transfer service by default. In case of container mode, specifically in GitHub the written file will be available in pyfluent.EXAMPLES_PATH directory by default. No need to download it explicitly in the GitHub test.

Right now it is failing at self._solver.download(scp_file_name) call because file_transfer_service is not provided.

If we still want to download it then we need add following code inside the test.

from ansys.fluent.core.utils.file_transfer_service import RemoteFileTransferStrategy
import ansys.fluent.core as pyfluent
from pathlib import Path
pyfluent.USE_FILE_TRANSFER_SERVICE = True
session = pyfluent.launch_fluent(file_transfer_service=RemoteFileTransferStrategy())
file_name = Path(pyfluent.EXAMPLES_PATH) / scp_file_name
session.download(file_name=file_name ) # it will download that file in `pyfluent.USER_DATA_PATH` by default for GitHub and in current working directory if we use wsl or Docker Desktop locally. 

[hpohekar]

@seanpearsonuk @mkundu1 @raph-luc wondering if you could offer any insight here. The test that I added is failing using v24.2.0 Fluent. Looks like it comes down to not being able to download the SCP file that Fluent generates from the container. So, either it's not using the download functionality correctly here:

pyfluent/src/ansys/fluent/core/systemcoupling.py

Line 92 in dcb2f69

# download the file locally in case Fluent is in a container

... or the download() function is not working on GitHub.
(the assert on line 96 in the above link fails)

@hpohekar Is it expected to work? Do we have relevant tests?

@seanpearsonuk

Is it expected to work? - No. It only works if we provide any file transfer service.

Do we have relevant tests? - Yes.

https://github.com/ansys/pyfluent/blob/main/tests/test_file_transfer_service.py#L42

[seanpearsonuk]

pyfluent.USE_FILE_TRANSFER_SERVICE = True
session = pyfluent.launch_fluent(file_transfer_service=RemoteFileTransferStrategy())

That's great, many thanks for the detailed response, @hpohekar.

@mkundu1 (et al) should file_transfer_service=RemoteFileTransferStrategy() simply override the module-level setting?