Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Launcher argvals refactoring #2822

Merged
merged 20 commits into from
May 17, 2024
Merged

refactor: Launcher argvals refactoring #2822

merged 20 commits into from
May 17, 2024

Conversation

hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented May 15, 2024 •
edited

closes #2818

  1. Updated self.<argument_name> to self.argvals['<argument_name>'].
  2. Removed use of setattr().

@hpohekar hpohekar mentioned this pull request May 15, 2024
Closed
@raph-luc raph-luc mentioned this pull request May 15, 2024
Merged
hpohekar and others added 6 commits May 16, 2024 09:35
@hpohekar @PipKat
Update src/ansys/fluent/core/launcher/pim_launcher.py
927e0d9 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@hpohekar @PipKat
Update src/ansys/fluent/core/launcher/pim_launcher.py
8b81630 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@hpohekar @PipKat
Update src/ansys/fluent/core/launcher/pim_launcher.py
ab3d621 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@hpohekar @PipKat
Update src/ansys/fluent/core/launcher/standalone_launcher.py
3b36304 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@pre-commit-ci
ci: auto fixes from pre-commit.com hooks
d3f4f0d 
for more information, see https://pre-commit.ci
@hpohekar
refactor container launcher
7c392b3
hpohekar and others added 4 commits May 16, 2024 23:09
@hpohekar
Merge branch 'main' into fix/launcher_argvals_refactoring
32d4bb1
@hpohekar @raph-luc
Update src/ansys/fluent/core/launcher/standalone_launcher.py
19b2de9 
Co-authored-by: Raphael Luciano <raphael.luciano@ansys.com>
@hpohekar @raph-luc
Update src/ansys/fluent/core/launcher/standalone_launcher.py
53140f3 
Co-authored-by: Raphael Luciano <raphael.luciano@ansys.com>
@raph-luc
refactor: using blacklist approach instead of whitelist for launch ar…
a3f8ceb 
…gs (#2826)

using blacklist approach instead of whitelist for launch args
@hpohekar hpohekar merged commit d2af58f into main May 17, 2024
26 checks passed
@hpohekar hpohekar deleted the fix/launcher_argvals_refactoring branch May 17, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@seanpearsonuk seanpearsonuk seanpearsonuk left review comments

@mkundu1 mkundu1 mkundu1 approved these changes

@raph-luc raph-luc raph-luc left review comments

@prmukherj prmukherj prmukherj approved these changes

@ajain-work ajain-work Awaiting requested review from ajain-work ajain-work is a code owner

@dnwillia-work dnwillia-work Awaiting requested review from dnwillia-work dnwillia-work is a code owner

@h-krishnan h-krishnan Awaiting requested review from h-krishnan h-krishnan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arg vals data management
6 participants
@hpohekar @PipKat @seanpearsonuk @mkundu1 @prmukherj @raph-luc