Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose additional task definition fields #368

Merged
merged 28 commits into from
Apr 26, 2024
Merged

Conversation

FedericoNegri
Copy link
Contributor

@FedericoNegri FedericoNegri commented Mar 21, 2024

No description provided.

@github-actions github-actions bot added the enhancement New features or code improvements label Mar 21, 2024
@github-actions github-actions bot added the maintenance Package and maintenance related label Mar 28, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.71%. Comparing base (5bb88c8) to head (9c17345).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
+ Coverage   93.63%   93.71%   +0.07%     
==========================================
  Files          62       62              
  Lines        2372     2402      +30     
==========================================
+ Hits         2221     2251      +30     
  Misses        151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FedericoNegri FedericoNegri marked this pull request as ready for review April 8, 2024 11:28
@FedericoNegri
Copy link
Contributor Author

@PipKat can you please review doc changes in the src/ansys/hps/client/jms/schema folder? (those in src/ansys/hps/client/jms/resources are autogenerated accordingly). Thanks

Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions to improve readability.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 10, 2024
@FedericoNegri FedericoNegri merged commit 809b425 into main Apr 26, 2024
21 checks passed
@FedericoNegri FedericoNegri deleted the feat/more-task-def-props branch April 26, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants