Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logic to stop the container and restart it to retrieve the files. #1430

Merged
merged 17 commits into from
Sep 5, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 31, 2022

Sometimes when the docker image fail, it seems to keep restarting all the time.
For example, from https://github.com/pyansys/pymapdl/runs/8101659895?check_suite_focus=true

Run docker exec mapdl /bin/bash -c "mkdir -p /mapdl_logs && echo 'Successfully created directory inside docker container'"
Error response from daemon: Container ea13c0211bc1709deb2eec408ca622cfe9a48aa86aa13a6384be85b53453ea64 is restarting, wait until the container is running
Error: Process completed with exit code 1.

So I'm implementing a logic to stop completely the container (overriding first the restarting policy) and then start it again, so I can retrieve the files (not running tests).

@germa89 germa89 added Enhancement Improve any current implemented feature CI/CD Related with CICD, Github Actions, etc labels Aug 31, 2022
@germa89 germa89 self-assigned this Aug 31, 2022
@github-actions github-actions bot added Maintenance General maintenance of the repo (libraries, cicd, etc) New Feature Request or proposal for a new feature labels Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #1430 (ede07bf) into main (0168868) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1430      +/-   ##
==========================================
- Coverage   79.77%   79.74%   -0.03%     
==========================================
  Files          43       43              
  Lines        6799     6799              
==========================================
- Hits         5424     5422       -2     
- Misses       1375     1377       +2     

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great idea, share with group if you'd like.

@germa89 germa89 merged commit 0fee35e into main Sep 5, 2022
@germa89 germa89 deleted the feat/improving-docker-files-retriever branch September 5, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc) New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants