-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding logic to stop the container and restart it to retrieve the files. #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germa89
added
Enhancement
Improve any current implemented feature
CI/CD
Related with CICD, Github Actions, etc
labels
Aug 31, 2022
github-actions
bot
added
Maintenance
General maintenance of the repo (libraries, cicd, etc)
New Feature
Request or proposal for a new feature
labels
Aug 31, 2022
Codecov Report
@@ Coverage Diff @@
## main #1430 +/- ##
==========================================
- Coverage 79.77% 79.74% -0.03%
==========================================
Files 43 43
Lines 6799 6799
==========================================
- Hits 5424 5422 -2
- Misses 1375 1377 +2 |
…d ANS_LOCK env var
The ans_lock was more than sufficient.
akaszynski
reviewed
Sep 2, 2022
akaszynski
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great idea, share with group if you'd like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/CD
Related with CICD, Github Actions, etc
Enhancement
Improve any current implemented feature
Maintenance
General maintenance of the repo (libraries, cicd, etc)
New Feature
Request or proposal for a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when the docker image fail, it seems to keep restarting all the time.
For example, from https://github.com/pyansys/pymapdl/runs/8101659895?check_suite_focus=true
So I'm implementing a logic to stop completely the container (overriding first the restarting policy) and then start it again, so I can retrieve the files (not running tests).