Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding commands to not be converted. #1442

Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 2, 2022

Adding more commands with empty args (--) to the COMMANDS_TO_NOT_BE_CONVERTED variable.

Close #1439

@germa89 germa89 added the Enhancement Improve any current implemented feature label Sep 2, 2022
@germa89 germa89 added this to the v0.63.3 milestone Sep 2, 2022
@germa89 germa89 self-assigned this Sep 2, 2022
@github-actions github-actions bot added the New Feature Request or proposal for a new feature label Sep 2, 2022
@akaszynski
Copy link
Collaborator

akaszynski commented Sep 2, 2022

Why not change the converter to use kwargs? It's more verbose, but I think it makes the scripts way more readable. Then we won't run into this issue.

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1442 (777d35b) into main (0a64c81) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1442   +/-   ##
=======================================
  Coverage   79.74%   79.75%           
=======================================
  Files          43       43           
  Lines        6799     6801    +2     
=======================================
+ Hits         5422     5424    +2     
  Misses       1377     1377           

@germa89
Copy link
Collaborator Author

germa89 commented Sep 5, 2022

@akaszynski

Failing style check because of:

src/ansys/mapdl/core/convert.py:43: LARG ==> LARGE
src/ansys/mapdl/core/convert.py:60: SMAL ==> SMALL

There is no option in codespell to ignore a single line, and I don't think it is a good idea to add "LARG" or "SMAL" to exceptions nor the whole file. Therefore, I will merge without style check completed once you approve the PR.

@germa89
Copy link
Collaborator Author

germa89 commented Sep 5, 2022

Why not change the converter to use kwargs? It's more verbose, but I think it makes the scripts way more readable. Then we won't run into this issue.

Are you thinking in something in particular? Maybe something like;

converted_script = convert_apdl_block(no_convert_commands=["LATT"])

??

@akaszynski akaszynski merged commit a8d51ed into main Sep 7, 2022
@akaszynski akaszynski deleted the feat/adding-exception-to-converter-to-handle-(--)-args branch September 7, 2022 14:29
germa89 added a commit that referenced this pull request Oct 11, 2022
* Expanding commands to not be converted.

* Fixing wrong mapping.
germa89 added a commit that referenced this pull request Oct 11, 2022
germa89 added a commit that referenced this pull request Oct 11, 2022
* Expanding commands to not be converted.

* Fixing wrong mapping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ansys.mapdl.core.converter_script wrong syntax for latt
2 participants