-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanding commands to not be converted. #1442
Expanding commands to not be converted. #1442
Conversation
Why not change the converter to use kwargs? It's more verbose, but I think it makes the scripts way more readable. Then we won't run into this issue. |
Codecov Report
@@ Coverage Diff @@
## main #1442 +/- ##
=======================================
Coverage 79.74% 79.75%
=======================================
Files 43 43
Lines 6799 6801 +2
=======================================
+ Hits 5422 5424 +2
Misses 1377 1377 |
Failing style check because of:
There is no option in codespell to ignore a single line, and I don't think it is a good idea to add "LARG" or "SMAL" to exceptions nor the whole file. Therefore, I will merge without style check completed once you approve the PR. |
Are you thinking in something in particular? Maybe something like; converted_script = convert_apdl_block(no_convert_commands=["LATT"]) ?? |
* Expanding commands to not be converted. * Fixing wrong mapping.
* Expanding commands to not be converted. * Fixing wrong mapping.
Adding more commands with empty args (
--
) to theCOMMANDS_TO_NOT_BE_CONVERTED
variable.Close #1439