Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reducing timeout for license check #1456

Merged
merged 6 commits into from
Sep 7, 2022
Merged

Reducing timeout for license check #1456

merged 6 commits into from
Sep 7, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 6, 2022

Reducing timeout for license check and adding message to notify user we are checking for licenses.

Implemented approach

>>> from ansys.mapdl.core import launch_mapdl
>>> mapdl = launch_mapdl()
PyMAPDL is taking more time than expected to connect to an MAPDL session.
We are checking the available licenses...

Close #1437

@germa89 germa89 added the Enhancement Improve any current implemented feature label Sep 6, 2022
@germa89 germa89 added this to the v0.64.0 milestone Sep 6, 2022
@germa89 germa89 self-assigned this Sep 6, 2022
@github-actions github-actions bot added the New Feature Request or proposal for a new feature label Sep 6, 2022
@codecov
Copy link

codecov bot commented Sep 6, 2022 •
edited

Codecov Report

Merging #1456 (98ab6a9) into main (0fee35e) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1456      +/-   ##
==========================================
+ Coverage   79.74%   80.03%   +0.28%     
==========================================
  Files          43       43              
  Lines        6799     6801       +2     
==========================================
+ Hits         5422     5443      +21     
+ Misses       1377     1358      -19

@germa89 germa89 changed the title Feat/reducing timeout for license check Reducing timeout for license check Sep 6, 2022
@akaszynski akaszynski enabled auto-merge (squash) September 7, 2022 00:56
@akaszynski akaszynski merged commit 38f844c into main Sep 7, 2022
@akaszynski akaszynski deleted the feat/reducing-timeout-for-license-check branch September 7, 2022 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski approved these changes

Assignees

@germa89 germa89

Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Milestone
v0.64.0
Development

Successfully merging this pull request may close these issues.

Improve license checking feedback
2 participants
@germa89 @akaszynski