Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math name issue #1465

Merged
merged 13 commits into from
Sep 15, 2022
Merged

Math name issue #1465

merged 13 commits into from
Sep 15, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 7, 2022

Fix math vector not being initialized when name was given. Added unit test to mapdl.mult.

Close #1464

@germa89 germa89 added the BUG Issue, problem or error in PyMAPDL label Sep 7, 2022
@germa89 germa89 added this to the v0.63.3 milestone Sep 7, 2022
@germa89 germa89 self-assigned this Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #1465 (a734458) into main (b67b2ce) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1465      +/-   ##
==========================================
+ Coverage   80.32%   80.37%   +0.04%     
==========================================
  Files          43       43              
  Lines        6780     6791      +11     
==========================================
+ Hits         5446     5458      +12     
+ Misses       1334     1333       -1     

Copy link
Collaborator Author

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

image

@germa89 germa89 merged commit d5e8fcb into main Sep 15, 2022
@germa89 germa89 deleted the fix/math-name-issue branch September 15, 2022 10:10
germa89 added a commit that referenced this pull request Oct 11, 2022
* Making sure the vector is generated even if not name is given.

* Adding unit tests

* Adding ``_parm`` to math module.

* Adding unit tests.

* changing test name.

* Adding LSENGINE case to parse *STATUS

* fixing tests

* commenting assert until we get feedback

* Fixing unit tests.

* Coverage.

* Fixing test

* Fixing test
germa89 added a commit that referenced this pull request Oct 11, 2022
germa89 added a commit that referenced this pull request Oct 11, 2022
* Making sure the vector is generated even if not name is given.

* Adding unit tests

* Adding ``_parm`` to math module.

* Adding unit tests.

* changing test name.

* Adding LSENGINE case to parse *STATUS

* fixing tests

* commenting assert until we get feedback

* Fixing unit tests.

* Coverage.

* Fixing test

* Fixing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located in mapdl.mult
1 participant