Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter improvements #1470

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Converter improvements #1470

merged 3 commits into from
Sep 15, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 7, 2022

Adding filename_out kwarg.

Replacing ending line with "\n". See https://docs.python.org/3/library/os.html#os.linesep

Adding spacing between code parts.

The style check won't pass because of LARG and SMAL commands.

Close #1468

Adding filename_out kwarg.

Replacing ending line with "\n".

Adding spacing between code parts.
@germa89 germa89 added the Enhancement Improve any current implemented feature label Sep 7, 2022
@germa89 germa89 added this to the v0.64.0 milestone Sep 7, 2022
@germa89 germa89 self-assigned this Sep 7, 2022
@github-actions github-actions bot added the New Feature Request or proposal for a new feature label Sep 7, 2022
@akaszynski
Copy link
Collaborator

Looks like we need to add some words to ignore_words.txt.

@germa89
Copy link
Collaborator Author

germa89 commented Sep 8, 2022

I thought that the style checker only happened in the edited/change text. It seems it happens always everywhere, so I'm adding the words in another PR (#1476 ) which I will merge first.

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #1470 (8c89968) into main (b67b2ce) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1470      +/-   ##
==========================================
+ Coverage   80.32%   80.38%   +0.05%     
==========================================
  Files          43       43              
  Lines        6780     6785       +5     
==========================================
+ Hits         5446     5454       +8     
+ Misses       1334     1331       -3     

Copy link
Collaborator Author

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@germa89 germa89 enabled auto-merge (squash) September 15, 2022 10:12
@germa89 germa89 merged commit 5e8a012 into main Sep 15, 2022
@germa89 germa89 deleted the feat/add-kwarg-to-convert-module branch September 15, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to use kwargs in convert_script
2 participants