Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: deprecate check_version.py in favor of pyansys-tools-versioning #1473

Merged
merged 12 commits into from
Jan 18, 2023

Conversation

jorgepiloto
Copy link
Member

This pull-request removes the check_version.py module in favor of the recently developed pyansys-tools-versioning library.

See issue ansys/pyansys-tools-versioning#4.

@github-actions github-actions bot added Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Sep 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Please add one of the following labels to add this contribution to the Release Notes 👇

@jorgepiloto
Copy link
Member Author

I see the style checks are complaining about a file that was not modified in this report. In addition, the tests seem to fail because some sort of connection error, I think.

Pinging here @germa89, just in case.

@germa89
Copy link
Collaborator

germa89 commented Sep 9, 2022

@jorgepiloto I did a merge from main which solved all the issues you mentioned, now only the PR specifics are left.

I will review when all the green ticks are in place.

@jorgepiloto
Copy link
Member Author

Back to this. Some tests need to be updated too, my fault.

@germa89
Copy link
Collaborator

germa89 commented Nov 22, 2022

@jorgepiloto any update on this?

@germa89
Copy link
Collaborator

germa89 commented Jan 9, 2023

Waiting for ansys/pyansys-tools-versioning#61 to be merged.

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@germa89
Copy link
Collaborator

germa89 commented Jan 18, 2023

Pinging @jorgepiloto for last opinion.

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #1473 (b4a6416) into main (1200969) will increase coverage by 81.62%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           main    #1473       +/-   ##
=========================================
+ Coverage      0   81.62%   +81.62%     
=========================================
  Files         0       44       +44     
  Lines         0     7710     +7710     
=========================================
+ Hits          0     6293     +6293     
- Misses        0     1417     +1417     

@germa89 germa89 merged commit f8b4539 into main Jan 18, 2023
@germa89 germa89 deleted the feat/requies-version branch January 18, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc) New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the use of pyansys-tools-versioning
2 participants