-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: deprecate check_version.py in favor of pyansys-tools-versioning #1473
Conversation
Please add one of the following labels to add this contribution to the Release Notes 👇 |
e7282f4
to
00ba7da
Compare
00ba7da
to
9a3e61f
Compare
I see the style checks are complaining about a file that was not modified in this report. In addition, the tests seem to fail because some sort of connection error, I think. Pinging here @germa89, just in case. |
@jorgepiloto I did a merge from main which solved all the issues you mentioned, now only the PR specifics are left. I will review when all the green ticks are in place. |
Back to this. Some tests need to be updated too, my fault. |
@jorgepiloto any update on this? |
Waiting for ansys/pyansys-tools-versioning#61 to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Pinging @jorgepiloto for last opinion. |
Codecov Report
@@ Coverage Diff @@
## main #1473 +/- ##
=========================================
+ Coverage 0 81.62% +81.62%
=========================================
Files 0 44 +44
Lines 0 7710 +7710
=========================================
+ Hits 0 6293 +6293
- Misses 0 1417 +1417 |
This pull-request removes the
check_version.py
module in favor of the recently developedpyansys-tools-versioning
library.See issue ansys/pyansys-tools-versioning#4.