Converter star slash improvements #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
germa89
added
BUG
|
Please add one of the following labels to add this contribution to the Release Notes 👇 |
Changing variables names.
akaszynski
reviewed
Sep 9, 2022
Codecov Report
@@ Coverage Diff @@
## main #1478 +/- ##
==========================================
+ Coverage 80.58% 80.64% +0.06%
==========================================
Files 43 43
Lines 6813 6830 +17
==========================================
+ Hits 5490 5508 +18
+ Misses 1323 1322 -1 |
germa89
commented
Sep 15, 2022
germa89
added a commit
that referenced
this pull request
Oct 11, 2022
* Adding only_commands option to converter. * Adding unit tests * fixing trailing commas issue * Removing unnecessary copy * Fixing unit tests. Changing variables names. * Another improvement * Changing variables name. * Changing variable name to lower caps. * Update tests/test_convert.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
only_commandskwarg to make it easier parse only commands, not scripts.Fix the conversion of commands which starts with
/or*.Added unit tests.
Close #1471