-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposure of Krylov Method for Frequency-Sweep Harmonic Analysis #1490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some suggestions, style wise mainly. I leave the math verification to @FredAns
After the tests are run successfully we will get the coverage percentage, we are aiming for 100% coverage, so you might need to add more cases, and test the non-valid input values.
I would recommend you to have a look at the following links:
- https://mapdl.docs.pyansys.com/contribution_and_api/index.html
- https://numpydoc.readthedocs.io/en/latest/example.html
Please implement the style checker (pre-commit
) by following the procedure specified in the first link.
Overall, there is a lot of work here and shows. I really like how well commented is your code. Good job and thank you for the addition!
doc/source/examples/extended_examples/Krylov/krylov_example.rst
Outdated
Show resolved
Hide resolved
doc/source/examples/extended_examples/Krylov/krylov_example.rst
Outdated
Show resolved
Hide resolved
doc/source/examples/extended_examples/Krylov/krylov_example.rst
Outdated
Show resolved
Hide resolved
doc/source/examples/extended_examples/Krylov/krylov_example.rst
Outdated
Show resolved
Hide resolved
doc/source/examples/extended_examples/Krylov/krylov_example.rst
Outdated
Show resolved
Hide resolved
doc/source/examples/extended_examples/Krylov/krylov_example.rst
Outdated
Show resolved
Hide resolved
doc/source/examples/extended_examples/Krylov/krylov_example.rst
Outdated
Show resolved
Hide resolved
doc/source/examples/extended_examples/Krylov/krylov_example.rst
Outdated
Show resolved
Hide resolved
doc/source/examples/extended_examples/Krylov/Harmonic_Analysis_using_krylov_pymapdl.rst
Outdated
Show resolved
Hide resolved
Things that are missing:
After that we can merge. |
Exposure of Krylov Method for Frequency-Sweep Harmonic Analysis
The Krylov Class has methods for the following :
1. krygensub : Creates the Krylov subspace
2. krysolve : Solves the reduced system of equations
3. kryexpand : Expands the Krylov subspace