Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping license checker once it is connected #1491

Merged
merged 13 commits into from
Sep 15, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 14, 2022

As the title.

I also refactored the license checker class so now all the functions are methods.

@germa89 germa89 added the Enhancement Improve any current implemented feature label Sep 14, 2022
@germa89 germa89 added this to the v0.63.3 milestone Sep 14, 2022
@germa89 germa89 self-assigned this Sep 14, 2022
@github-actions github-actions bot added the New Feature Request or proposal for a new feature label Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #1491 (17e68ca) into main (3d21ac6) will increase coverage by 1.27%.
The diff coverage is 90.80%.

@@            Coverage Diff             @@
##             main    #1491      +/-   ##
==========================================
+ Coverage   80.32%   81.59%   +1.27%     
==========================================
  Files          43       43              
  Lines        6779     6737      -42     
==========================================
+ Hits         5445     5497      +52     
+ Misses       1334     1240      -94     

Copy link
Collaborator Author

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes.

src/ansys/mapdl/core/licensing.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/licensing.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/licensing.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/licensing.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/licensing.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/licensing.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/licensing.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/licensing.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/logging.py Outdated Show resolved Hide resolved
@germa89 germa89 merged commit b7700a9 into main Sep 15, 2022
@germa89 germa89 deleted the feat/stopping-license-checker-once-it-is-connected- branch September 15, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant