Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapdl.use uploads macro file to remote instance #1509

Merged
merged 4 commits into from
Sep 30, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 23, 2022

As the title.

@germa89 germa89 added the Enhancement Improve any current implemented feature label Sep 23, 2022
@germa89 germa89 added this to the v0.64.0 milestone Sep 23, 2022
@germa89 germa89 self-assigned this Sep 23, 2022
@github-actions github-actions bot added the New Feature Request or proposal for a new feature label Sep 23, 2022
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #1509 (ddf165a) into main (6158e63) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1509      +/-   ##
==========================================
+ Coverage   81.76%   81.90%   +0.13%     
==========================================
  Files          43       43              
  Lines        6784     6797      +13     
==========================================
+ Hits         5547     5567      +20     
+ Misses       1237     1230       -7     

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good testing coverage.

tests/test_mapdl.py Outdated Show resolved Hide resolved
@germa89 germa89 merged commit ee04620 into main Sep 30, 2022
@germa89 germa89 deleted the feat/use-uploads-macro-file branch September 30, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants