Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing licensing in docker building cicd #1521

Merged
merged 4 commits into from
Sep 30, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 30, 2022

The docker image builiding was failing because of two things:

  • Unsufficient time given to some license check threads
  • The tests that requires license binaries were being executed although the testing was made in remote way.

I have added the local requirement to the license binaries tests, and also increased the waiting time before checking threads health.

Pinging @dts12263 for visibility

@germa89 germa89 added BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc labels Sep 30, 2022
@germa89 germa89 self-assigned this Sep 30, 2022
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #1521 (fd59166) into main (157f0bf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1521   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files          43       43           
  Lines        6784     6784           
=======================================
  Hits         5547     5547           
  Misses       1237     1237           

@germa89 germa89 merged commit 26ad1ac into main Sep 30, 2022
@germa89 germa89 deleted the fix/licensing-in-docker-building-CICD branch September 30, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant