Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking against existing MATH parameters #1537

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 11, 2022

The parameter check should be done on the capital version of the parameter name:

if name.upper() not in self._parm:
    self._mapdl.run(f"*VEC,{name},{MYCTYPE[dtype]},ALLOC,{size}", mute=True)

@germa89 germa89 added the BUG Issue, problem or error in PyMAPDL label Oct 11, 2022
@germa89 germa89 added this to the v0.63.3 milestone Oct 11, 2022
@germa89 germa89 self-assigned this Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #1537 (fa4bd80) into main (5229491) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1537   +/-   ##
=======================================
  Coverage   81.80%   81.80%           
=======================================
  Files          43       43           
  Lines        6797     6797           
=======================================
  Hits         5560     5560           
  Misses       1237     1237           

@germa89 germa89 merged commit 756c199 into main Oct 11, 2022
@germa89 germa89 deleted the fix/checking-the-parameter-in-math._parm branch October 11, 2022 14:37
germa89 added a commit that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant