Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommandOutput improvements #1554

Merged
merged 15 commits into from
Oct 24, 2022
Merged

CommandOutput improvements #1554

merged 15 commits into from
Oct 24, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 14, 2022

  • Allow magicwords kwarg definition when instantiating CommandListingOutput class
  • Fix a bug that omitted the last number on the listing, and another parsing issue which killed the lathe example.
  • Wrapping set,list with the command output listing
  • exposing mapdl.post_processing.set using the wrapped set,list
  • Also fixing an reference in post table

This is a perfect example of spaghetti issue... you start with something simple and fixing small things, and then you end up rewriting a lot of stuff.

@germa89 germa89 added BUG Issue, problem or error in PyMAPDL Enhancement Improve any current implemented feature Documentation Documentation related (improving, adding, etc) New Feature Request or proposal for a new feature labels Oct 14, 2022
@germa89 germa89 added this to the v0.64.0 milestone Oct 14, 2022
@germa89 germa89 self-assigned this Oct 14, 2022
@germa89
Copy link
Collaborator Author

germa89 commented Oct 14, 2022

Style checks fails because I actually want the raw MAPDL output which includes spaces at the end of several lines.

I will force the merge when the other ticks are green.

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #1554 (72d96c9) into main (726cfe3) will increase coverage by 0.04%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##             main    #1554      +/-   ##
==========================================
+ Coverage   82.17%   82.21%   +0.04%     
==========================================
  Files          43       43              
  Lines        6821     6843      +22     
==========================================
+ Hits         5605     5626      +21     
- Misses       1216     1217       +1     

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) labels Oct 17, 2022
@germa89 germa89 merged commit 87f54fe into main Oct 24, 2022
@germa89 germa89 deleted the feat/-adding-set-to-post branch October 24, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc Documentation Documentation related (improving, adding, etc) Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc) New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant