-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload test for DPF #1557
Merged
Merged
Upload test for DPF #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Maintenance
General maintenance of the repo (libraries, cicd, etc)
Enhancement
Improve any current implemented feature
New Feature
Request or proposal for a new feature
labels
Oct 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #1557 +/- ##
==========================================
+ Coverage 79.44% 82.71% +3.26%
==========================================
Files 44 44
Lines 7141 7143 +2
==========================================
+ Hits 5673 5908 +235
+ Misses 1468 1235 -233 |
germa89
changed the title
Using private docker image in CICD to avoid upload issue.
Upload test for DPF
Oct 24, 2022
germa89
commented
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/CD
Related with CICD, Github Actions, etc
Enhancement
Improve any current implemented feature
Maintenance
General maintenance of the repo (libraries, cicd, etc)
New Feature
Request or proposal for a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the latest private images do not have the issue ansys/pydpf-core#466 hence I'm going to use them until standalone happens.
== Edit ==
Because of #1449 this PR has been left with not much of the original purpose, however, it is still useful.
Adding test for uploading and improving some tests and functions