Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload test for DPF #1557

Merged
merged 15 commits into from
Oct 25, 2022
Merged

Upload test for DPF #1557

merged 15 commits into from
Oct 25, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 17, 2022

It seems the latest private images do not have the issue ansys/pydpf-core#466 hence I'm going to use them until standalone happens.

== Edit ==

Because of #1449 this PR has been left with not much of the original purpose, however, it is still useful.

Adding test for uploading and improving some tests and functions

@germa89 germa89 added the CI/CD Related with CICD, Github Actions, etc label Oct 17, 2022
@germa89 germa89 self-assigned this Oct 17, 2022
@github-actions github-actions bot added Maintenance General maintenance of the repo (libraries, cicd, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Oct 17, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #1557 (dd3a4e3) into main (c326838) will increase coverage by 3.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1557      +/-   ##
==========================================
+ Coverage   79.44%   82.71%   +3.26%     
==========================================
  Files          44       44              
  Lines        7141     7143       +2     
==========================================
+ Hits         5673     5908     +235     
+ Misses       1468     1235     -233     

@germa89 germa89 closed this Oct 19, 2022
@germa89 germa89 reopened this Oct 19, 2022
@germa89 germa89 changed the title Using private docker image in CICD to avoid upload issue. Upload test for DPF Oct 24, 2022
Copy link
Collaborator Author

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@germa89 germa89 merged commit 1b6ca17 into main Oct 25, 2022
@germa89 germa89 deleted the feat/using-dpf-private-image branch October 25, 2022 11:06
@germa89 germa89 mentioned this pull request Oct 28, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc) New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant