Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using multiple PR for dependabot #1574

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Using multiple PR for dependabot #1574

merged 3 commits into from
Nov 2, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 21, 2022

No description provided.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Oct 21, 2022
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #1574 (e84b021) into main (726cfe3) will increase coverage by 0.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1574      +/-   ##
==========================================
+ Coverage   82.17%   82.82%   +0.65%     
==========================================
  Files          43       44       +1     
  Lines        6821     7151     +330     
==========================================
+ Hits         5605     5923     +318     
- Misses       1216     1228      +12     

@germa89
Copy link
Collaborator Author

germa89 commented Oct 24, 2022

I should check this locally first.

@germa89
Copy link
Collaborator Author

germa89 commented Oct 31, 2022

I'm going to test this in a smaller repo

@akaszynski
Copy link
Collaborator

@germa89, if you'd like, submit a PR for https://github.com/pyvista/pyvista

Copy link
Collaborator Author

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

.github/workflows/dependabot.yml Outdated Show resolved Hide resolved
.github/workflows/dependabot.yml Outdated Show resolved Hide resolved
@germa89 germa89 merged commit 19c1d98 into main Nov 2, 2022
@germa89 germa89 deleted the feat/dependabot-multi branch November 2, 2022 14:23
@germa89
Copy link
Collaborator Author

germa89 commented Nov 2, 2022

@germa89, if you'd like, submit a PR for https://github.com/pyvista/pyvista

I will do that after I check how it works on PyMAPDL. I am concerned on how it will interact with the actual dependabot (will it disable it? or will it complement it? ... I guess the second).

Let's give it a week to this one.

@germa89
Copy link
Collaborator Author

germa89 commented Nov 21, 2022

This is the output.... #1638

Basically it didnt ignore the packages.. and it seems it cannot run properly....

@germa89 germa89 mentioned this pull request Nov 21, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc) New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants