Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements in sphinx build #1583

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Small improvements in sphinx build #1583

merged 3 commits into from
Oct 26, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 25, 2022

As proposed by @akaszynski

Also added yellow role for text colouring.

@github-actions github-actions bot added Documentation Documentation related (improving, adding, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Oct 25, 2022
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #1583 (8809b47) into main (1b6ca17) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1583      +/-   ##
==========================================
- Coverage   82.82%   82.71%   -0.12%     
==========================================
  Files          44       44              
  Lines        7143     7143              
==========================================
- Hits         5916     5908       -8     
- Misses       1227     1235       +8     

@akaszynski
Copy link
Collaborator

Doc build goes from 7 minutes to 30. Not sure what's causing this huge increase, so I'm rerunning with a trivial fix to see if it's because of a cache miss.

doc/source/conf.py Outdated Show resolved Hide resolved
@akaszynski
Copy link
Collaborator

Found the issue. We were overwriting the html theme settings in a1c4ff7.

doc/source/conf.py Outdated Show resolved Hide resolved
Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>
@RobPasMue RobPasMue self-requested a review October 26, 2022 12:33
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit ff3a9a8 into main Oct 26, 2022
@germa89 germa89 deleted the feat/building-improvements branch October 26, 2022 12:34
@germa89
Copy link
Collaborator Author

germa89 commented Oct 26, 2022

Thank you @RobPasMue !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related (improving, adding, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants