Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary file coverage.xml #1617

Merged
merged 5 commits into from
Nov 7, 2022
Merged

Unnecessary file coverage.xml #1617

merged 5 commits into from
Nov 7, 2022

Conversation

clatapie
Copy link
Contributor

@clatapie clatapie commented Nov 7, 2022

Solves #1613

@clatapie clatapie linked an issue Nov 7, 2022 that may be closed by this pull request
Unnecessary file coverage.xml #1613
Closed
3 tasks
@github-actions github-actions bot added Dependencies BUG Issue, problem or error in PyMAPDL labels Nov 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

Please add one of the following labels to add this contribution to the Release Notes 👇

@clatapie clatapie self-assigned this Nov 7, 2022
@codecov
Copy link

codecov bot commented Nov 7, 2022 •
edited

Codecov Report

Merging #1617 (b843edf) into main (f6faa9b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1617   +/-   ##
=======================================
  Coverage   82.81%   82.81%           
=======================================
  Files          44       44           
  Lines        7151     7151           
=======================================
  Hits         5922     5922           
  Misses       1229     1229

RobPasMue
RobPasMue approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

requirements/requirements_docs.txt Outdated Show resolved Hide resolved
requirements/requirements_tests.txt Outdated Show resolved Hide resolved
@clatapie @RobPasMue
Apply suggestions from code review
73af9c2 
Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>
RobPasMue
RobPasMue reviewed Nov 7, 2022
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@clatapie clatapie marked this pull request as ready for review November 7, 2022 14:47
germa89
germa89 approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good idea!

@germa89
Copy link
Collaborator

germa89 commented Nov 7, 2022

Feel free to Squash and merge @clatapie ! :)

@clatapie clatapie merged commit 7a0677b into main Nov 7, 2022
@clatapie clatapie deleted the fix/unnecessary-file-coverage-xml branch November 7, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@germa89 germa89 germa89 approved these changes

Assignees

@clatapie clatapie

Labels
BUG Issue, problem or error in PyMAPDL Dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary file coverage.xml
3 participants
@clatapie @germa89 @RobPasMue