Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding debugging information #1660

Merged
merged 14 commits into from
Dec 7, 2022
Merged

Adding debugging information #1660

merged 14 commits into from
Dec 7, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 29, 2022

Close #1652 and also add much more information to logger output.

@germa89 germa89 added the Documentation Documentation related (improving, adding, etc) label Nov 29, 2022
@germa89 germa89 self-assigned this Nov 29, 2022
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022 •
edited

Codecov Report

Merging #1660 (965978e) into main (82a9e72) will decrease coverage by 0.05%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #1660      +/-   ##
==========================================
- Coverage   85.21%   85.15%   -0.06%     
==========================================
  Files          45       45              
  Lines        7466     7511      +45     
==========================================
+ Hits         6362     6396      +34     
- Misses       1104     1115      +11

@germa89 germa89 requested a review from PipKat November 30, 2022 19:20
@germa89
Copy link
Collaborator Author

germa89 commented Dec 1, 2022

I'm not going to bother about coverage now. I will do a later PR to increase coverage.

PipKat
PipKat reviewed Dec 1, 2022
View reviewed changes
src/ansys/mapdl/core/misc.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Dec 1, 2022
View reviewed changes
src/ansys/mapdl/core/misc.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Dec 1, 2022
View reviewed changes
src/ansys/mapdl/core/misc.py Outdated Show resolved Hide resolved
germa89
germa89 commented Dec 5, 2022
View reviewed changes
src/ansys/mapdl/core/misc.py Outdated Show resolved Hide resolved
germa89 and others added 2 commits December 5, 2022 15:04
@germa89 germa89 enabled auto-merge (squash) December 7, 2022 17:09
@germa89 germa89 merged commit f2c566d into main Dec 7, 2022
@germa89 germa89 deleted the feat/adding-debugging-information branch December 7, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat approved these changes

Assignees

@germa89 germa89

Labels
CI/CD Related with CICD, Github Actions, etc Documentation Documentation related (improving, adding, etc) Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc) New Feature Request or proposal for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add info about debugging
2 participants
@germa89 @PipKat