Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding google analytics tag #1740

Merged
merged 3 commits into from
Dec 29, 2022
Merged

Adding google analytics tag #1740

merged 3 commits into from
Dec 29, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Dec 28, 2022

To improve user experience we are going to track the doc website usage, so we can see what parts of the website are more visited.

@germa89 germa89 added Enhancement Improve any current implemented feature Documentation Documentation related (improving, adding, etc) labels Dec 28, 2022
@germa89 germa89 self-assigned this Dec 28, 2022
@github-actions github-actions bot added the New Feature Request or proposal for a new feature label Dec 28, 2022
@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Merging #1740 (bcb1b07) into main (673ee55) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1740      +/-   ##
==========================================
- Coverage   85.55%   85.53%   -0.02%     
==========================================
  Files          45       45              
  Lines        7587     7660      +73     
==========================================
+ Hits         6491     6552      +61     
- Misses       1096     1108      +12     

@germa89
Copy link
Collaborator Author

germa89 commented Dec 28, 2022

Failing because a warning in docs.

This warning will be fixed after sphinx-contrib/googleanalytics#7 is closed and a new release is done.

If it takes too much time to fix the above issue, I will just go ahead and implement the tag by myself.

@germa89 germa89 merged commit e8e2ef6 into main Dec 29, 2022
@germa89 germa89 deleted the feat/google-analytics branch December 29, 2022 15:16
@germa89
Copy link
Collaborator Author

germa89 commented Dec 29, 2022

Failing because a warning in docs.

This warning will be fixed after sphinx-contrib/googleanalytics#7 is closed and a new release is done.

If it takes too much time to fix the above issue, I will just go ahead and implement the tag by myself.

I end up using the 'master' branch (see toml file)

@germa89
Copy link
Collaborator Author

germa89 commented Jan 5, 2023

It is working!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related (improving, adding, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants