Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating allow_ignore in favor of ignore_errors #1743

Merged
merged 6 commits into from
Dec 29, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Dec 29, 2022

While working on #1664

I saw that ignore_errors does nothing, in fact it is redundant with allow_ignore. The later is more common, but I believe the naming is not the best.

So I am redirecting allow_ignore to ignore_errors and issuing a Deprecation warning when allow_ignore is used or set.

@germa89 germa89 self-assigned this Dec 29, 2022
@github-actions github-actions bot added Documentation Documentation related (improving, adding, etc) BUG Issue, problem or error in PyMAPDL labels Dec 29, 2022
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #1743 (2e30705) into main (326b802) will decrease coverage by 4.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1743      +/-   ##
==========================================
- Coverage   85.57%   81.42%   -4.15%     
==========================================
  Files          45       45              
  Lines        7630     7660      +30     
==========================================
- Hits         6529     6237     -292     
- Misses       1101     1423     +322     

@germa89 germa89 merged commit 8e8ae3f into main Dec 29, 2022
@germa89 germa89 deleted the fix/allow-errors-being-bypassed branch December 29, 2022 16:39
@germa89 germa89 mentioned this pull request Mar 15, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants