-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catching MAPDL process output #1746
Conversation
Adding support for process checking. Adding unit tests and docs.
Codecov Report
@@ Coverage Diff @@
## main #1746 +/- ##
==========================================
- Coverage 85.60% 81.51% -4.09%
==========================================
Files 45 45
Lines 7667 7743 +76
==========================================
- Hits 6563 6312 -251
- Misses 1104 1431 +327 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@clatapie please have a look at this PR. I think it is an interesting one! |
The ubuntu local test keeps getting stuck on the Inteeeresttinggggg... |
Last commit just to check if a newly created run fixes the test. Of course it should not... but who knows. |
New features
Several things are done in this PR:
Added
mapdl.launched
property. This isTrue
if we have started the mapdl process. It is similar tomapdl.local
. However you can havemapdl.local
equal toTrue
(mapdl instance running on the same machine) butmapdl.launched
equalsFalse
because you manually launched. Another PR should follow up to clarify/unifymapdl.local
usage.Adding support for process checking. Now if we fail to connect to MAPDL, we automatically check the process (
subprocess.Popen
) output and we raise anyerror
,warning
orfatal
erros we find.subprocess.Popen
) is now accessible onmapdl._mapdl_process
ingrpc
andcorba
modes.corba
mode.verbose
argument incorba
andgrpc
classes.Caveats
subprocess.PIPE
object. It should have no effect on the normal MAPDL work mode because of the arguments-o
supplied (in Windows). Because of this redirection, verbose needs to be deprecated (verbose redirect the output to screen?)