Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapting test_cwd to work in local and remote #1751

Merged
merged 6 commits into from
Jan 4, 2023
Merged

Adapting test_cwd to work in local and remote #1751

merged 6 commits into from
Jan 4, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 3, 2023

No description provided.

@germa89 germa89 added BUG Issue, problem or error in PyMAPDL Enhancement Improve any current implemented feature CI/CD Related with CICD, Github Actions, etc labels Jan 3, 2023
@germa89 germa89 requested a review from clatapie January 3, 2023 16:28
@germa89 germa89 self-assigned this Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023 •
edited

Codecov Report

Merging #1751 (dbde0bd) into main (8e8ae3f) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1751      +/-   ##
==========================================
- Coverage   85.56%   85.51%   -0.05%     
==========================================
  Files          45       45              
  Lines        7660     7663       +3     
==========================================
- Hits         6554     6553       -1     
- Misses       1106     1110       +4

@germa89
Copy link
Collaborator Author

germa89 commented Jan 4, 2023

I worked in the first commit on a remote container, and for some reason git thinks I changed the full file (probably the owner was changed?).

This is not very convenient but I dont think it is worth to investigate much more.

@germa89
Copy link
Collaborator Author

germa89 commented Jan 4, 2023

I worked in the first commit on a remote container, and for some reason git thinks I changed the full file (probably the owner was changed?).

This is not very convenient but I dont think it is worth to investigate much more.

Kind of fixed.

@germa89
Copy link
Collaborator Author

germa89 commented Jan 4, 2023

@clatapie can you have a look at this before I merge?

clatapie
clatapie approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@germa89
Copy link
Collaborator Author

germa89 commented Jan 4, 2023

LGTM! 👍

Thank you! :D

@germa89 germa89 merged commit ff1c818 into main Jan 4, 2023
@germa89 germa89 deleted the fix/test_cwd branch January 4, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clatapie clatapie clatapie approved these changes

Assignees

@germa89 germa89

Labels
BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc Enhancement Improve any current implemented feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@germa89 @clatapie