Improving ubuntu devcontainer #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Enhancement
Codecov Report
@@ Coverage Diff @@
## main #1752 +/- ##
==========================================
- Coverage 85.86% 80.91% -4.95%
==========================================
Files 44 44
Lines 7844 7844
==========================================
- Hits 6735 6347 -388
- Misses 1109 1497 +388 |
akaszynski
reviewed
Jan 12, 2023
akaszynski
reviewed
Jan 12, 2023
akaszynski
reviewed
Jan 12, 2023
akaszynski
reviewed
Jan 12, 2023
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
akaszynski
reviewed
Jan 12, 2023
|
Legal issues leave this PR a bit of without scope. Basically, we can't provide users with docker images. Hence this whole approach for devops lacks of purpose, unless it is just to give some guidance, so the users can build their own docker images. But that is a different story. However I think the approach still works internally (hence I'm going to keep the configuration files) but I will rework the documentation to explain a bit the process for users. |
…om/pyansys/pymapdl into feat/improving-ubuntu-devcontainer
…om/pyansys/pymapdl into feat/improving-ubuntu-devcontainer
akaszynski
approved these changes
Feb 22, 2023
|
LGTM |
pyansys-ci-bot
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smoothing the usage of our docker image in codespace and as remote container.