Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct dependency #1786

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Remove direct dependency #1786

merged 1 commit into from
Jan 18, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 18, 2023

To do a release we need to remove all the direct (git based) dependencies.

The direct dependency was there because there was no release with the changes I proposed to this library in here: sphinx-contrib/googleanalytics#7

@germa89 germa89 added the Enhancement Improve any current implemented feature label Jan 18, 2023
@germa89 germa89 requested a review from clatapie January 18, 2023 14:18
@germa89 germa89 self-assigned this Jan 18, 2023
@github-actions github-actions bot added Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc) New Feature Request or proposal for a new feature labels Jan 18, 2023
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #1786 (417eace) into main (f21ade3) will increase coverage by 78.42%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           main    #1786       +/-   ##
=========================================
+ Coverage      0   78.42%   +78.42%     
=========================================
  Files         0       44       +44     
  Lines         0     7709     +7709     
=========================================
+ Hits          0     6046     +6046     
- Misses        0     1663     +1663     

@germa89 germa89 merged commit 4252ecf into main Jan 18, 2023
@germa89 germa89 deleted the feat/removing-direct-dependency branch January 18, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc) New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant