Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for converter CLI #1789

Merged
merged 6 commits into from
Jan 24, 2023
Merged

Added documentation for converter CLI #1789

merged 6 commits into from
Jan 24, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 19, 2023

Close #1785

@germa89 germa89 added the Documentation Documentation related (improving, adding, etc) label Jan 19, 2023
@germa89 germa89 requested a review from PipKat January 19, 2023 13:35
@germa89 germa89 self-assigned this Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #1789 (8521c1b) into main (e1d3e9a) will increase coverage by 81.78%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           main    #1789       +/-   ##
=========================================
+ Coverage      0   81.78%   +81.78%     
=========================================
  Files         0       44       +44     
  Lines         0     7709     +7709     
=========================================
+ Hits          0     6305     +6305     
- Misses        0     1404     +1404     

Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@germa89 Most edits were to follow the Google style guide.

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@germa89
Copy link
Collaborator Author

germa89 commented Jan 24, 2023

Thank you @PipKat for your comments. Very useful!!

@germa89 germa89 merged commit 6e7f282 into main Jan 24, 2023
@germa89 germa89 deleted the doc/converter-cli branch January 24, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converter CLI needs to be documented
2 participants