Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate macOS wheels when releasing #1795

Merged
merged 8 commits into from
Jan 24, 2023
Merged

Generate macOS wheels when releasing #1795

merged 8 commits into from
Jan 24, 2023

Conversation

RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Jan 20, 2023 •
edited by germa89

As title says.

Close #1217

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc) labels Jan 20, 2023
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@RobPasMue RobPasMue self-assigned this Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023 •
edited

Codecov Report

Merging #1795 (263da81) into main (be8ff4a) will increase coverage by 81.78%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           main    #1795       +/-   ##
=========================================
+ Coverage      0   81.78%   +81.78%     
=========================================
  Files         0       44       +44     
  Lines         0     7709     +7709     
=========================================
+ Hits          0     6305     +6305     
- Misses        0     1404     +1404

@RobPasMue RobPasMue mentioned this pull request Jan 20, 2023
Closed
@RobPasMue RobPasMue linked an issue Jan 20, 2023 that may be closed by this pull request
Supporting MacOS using wheels #1217
Closed
clatapie
clatapie approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

germa89
germa89 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @RobPasMue !! :)

@germa89 germa89 merged commit 6fa48bb into main Jan 24, 2023
@germa89 germa89 deleted the maint/macos-wheels branch January 24, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germa89 germa89 germa89 approved these changes

@clatapie clatapie clatapie approved these changes

@akaszynski akaszynski Awaiting requested review from akaszynski

Assignees

@RobPasMue RobPasMue

Labels
CI/CD Related with CICD, Github Actions, etc Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supporting MacOS using wheels
3 participants
@RobPasMue @germa89 @clatapie