Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering out the extra zips #1800

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Filtering out the extra zips #1800

merged 2 commits into from
Jan 26, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 24, 2023

Close #1794

@germa89 germa89 added BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) labels Jan 24, 2023
@germa89 germa89 requested a review from a team January 24, 2023 10:48
@germa89 germa89 self-assigned this Jan 24, 2023
@germa89 germa89 requested review from clatapie and removed request for a team January 24, 2023 10:48
@codecov
Copy link

codecov bot commented Jan 24, 2023 •
edited

Codecov Report

Merging #1800 (fddd1fb) into main (4dd48b7) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1800      +/-   ##
==========================================
- Coverage   85.72%   85.69%   -0.04%     
==========================================
  Files          44       44              
  Lines        7875     7809      -66     
==========================================
- Hits         6751     6692      -59     
+ Misses       1124     1117       -7

clatapie
clatapie approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 enabled auto-merge (squash) January 26, 2023 16:59
@germa89 germa89 disabled auto-merge January 26, 2023 17:17
@germa89 germa89 merged commit 0dd219b into main Jan 26, 2023
@germa89 germa89 deleted the maint/remove-extra-zip-files branch January 26, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clatapie clatapie clatapie approved these changes

Assignees

@germa89 germa89

Labels
BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove extra zip from release artifacts
2 participants
@germa89 @clatapie