Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving stability of ubuntu local tests #1801

Merged
merged 30 commits into from
Jan 26, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 24, 2023

Several things but mainly:

Improved stability in Local Ubuntu tests

Close #1804 #1755

But also:

  • New checks for MAPDL launching issues (process, error file and command output (only linux)).
  • Using an env var RUN_LOCAL for running local. A follow up PR should come to point all the test fixtures to it.
  • Added check for process is alive.
  • PIDs are also cached from the subprocess.
  • Improved killing process. Related to Improving process killing #1700. Close Linux does not close the processes #1805

Additionally fixes #1792 because that workflow needs the whole CI workflow to be successful in order to identify the artefacts.

@germa89 germa89 self-assigned this Jan 24, 2023
@github-actions github-actions bot added the BUG Issue, problem or error in PyMAPDL label Jan 24, 2023
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #1801 (6f64227) into main (be8ff4a) will increase coverage by 80.86%.
The diff coverage is 28.07%.

@@            Coverage Diff            @@
##           main    #1801       +/-   ##
=========================================
+ Coverage      0   80.86%   +80.86%     
=========================================
  Files         0       44       +44     
  Lines         0     7809     +7809     
=========================================
+ Hits          0     6315     +6315     
- Misses        0     1494     +1494     

@germa89 germa89 marked this pull request as ready for review January 26, 2023 15:45
@germa89 germa89 requested review from a team and clatapie and removed request for a team January 26, 2023 15:45
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting PR! LGTM 👍

src/ansys/mapdl/core/launcher.py Outdated Show resolved Hide resolved
Co-authored-by: Camille <78221213+clatapie@users.noreply.github.com>
@germa89 germa89 enabled auto-merge (squash) January 26, 2023 16:00
@germa89 germa89 merged commit 4dd48b7 into main Jan 26, 2023
@germa89 germa89 deleted the fix/improving-stability-of-ubuntu-local-tests branch January 26, 2023 16:44
@germa89
Copy link
Collaborator Author

germa89 commented Jan 26, 2023

Finally...

omg...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
2 participants