Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use grpcio==1.51.1 for docbuild #1807

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Use grpcio==1.51.1 for docbuild #1807

merged 1 commit into from
Jan 26, 2023

Conversation

akaszynski
Copy link
Collaborator

Use the latest grpcio to better support Python 3.11 for doc builds.

@akaszynski akaszynski changed the title Use grpcio==1.51.1 Use grpcio==1.51.1 for docbuild Jan 26, 2023
@github-actions github-actions bot added Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc) BUG Issue, problem or error in PyMAPDL labels Jan 26, 2023
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@akaszynski
Copy link
Collaborator Author

@germa89, github tells me to add a label, but then it just adds labels. Let's just remove the feedback and have it automagically add labels.

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@germa89
Copy link
Collaborator

germa89 commented Jan 26, 2023

@germa89, github tells me to add a label, but then it just adds labels. Let's just remove the feedback and have it automagically add labels.

Roger!

@germa89
Copy link
Collaborator

germa89 commented Jan 26, 2023

@akaszynski

I'm checking if there is no contraindication for updates (you know... unsupport older grpc versions, etc)

https://github.com/grpc/grpc/releases

I did not see anything. So I guess it is fine

@germa89 germa89 enabled auto-merge (squash) January 26, 2023 18:32
@germa89 germa89 merged commit b223928 into main Jan 26, 2023
@germa89 germa89 deleted the fix/support-grpcio-latest branch January 26, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants