Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing spaces in parameter string #1829

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 31, 2023

Close #1826 by making sure a correct parsing when string parameters contain spaces.

@germa89 germa89 requested review from a team and clatapie and removed request for a team January 31, 2023 16:29
@github-actions github-actions bot added the BUG Issue, problem or error in PyMAPDL label Jan 31, 2023
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #1829 (dec7515) into main (e17d336) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1829      +/-   ##
==========================================
- Coverage   85.84%   85.67%   -0.18%     
==========================================
  Files          44       44              
  Lines        7809     7810       +1     
==========================================
- Hits         6704     6691      -13     
- Misses       1105     1119      +14     

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@germa89 germa89 merged commit 16ccd89 into main Feb 1, 2023
@germa89 germa89 deleted the fix/storing-characters-with-spaces branch February 1, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mapdl.parameters will trigger error with "character" parameters
2 participants