Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recache processes to make sure we close them all. #1831

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 1, 2023

This come from internal request:

this is a follow-up on my last service request.
We had issues with closing processes when using the SMP mode within a PyAnsys script.
Your service member O.R. helped a lot and suggested to upgrade our python package with the following command.
pip install --upgrade --upgrade-strategy eager ansys-mapdl-core The issue unfortunately still exists.
DMP mode seem to work just fine with my crack growth (SMART) analysis.

I did try locally in ubuntu container, and on Windows 11; and it seems to work.

I will ask for internal feedback.

=Edit=
I have also added the module atexit to track exiting python using __del__ method properly.
Close #1812

@germa89 germa89 added the Enhancement Improve any current implemented feature label Feb 1, 2023
@germa89 germa89 self-assigned this Feb 1, 2023
@github-actions github-actions bot added the New Feature Request or proposal for a new feature label Feb 1, 2023
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #1831 (9c95b41) into main (4e93251) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1831   +/-   ##
=======================================
  Coverage   85.69%   85.69%           
=======================================
  Files          44       44           
  Lines        7809     7811    +2     
=======================================
+ Hits         6692     6694    +2     
  Misses       1117     1117           

@germa89 germa89 requested review from a team and clatapie and removed request for a team February 2, 2023 11:20
@germa89 germa89 merged commit dc28bfc into main Feb 2, 2023
@germa89 germa89 deleted the feat/improving-killing-process branch February 2, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__del__ method still shows an exception when closing Python
3 participants