Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying the Sphinx dependency version #1850

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Modifying the Sphinx dependency version #1850

merged 1 commit into from
Feb 8, 2023

Conversation

clatapie
Copy link
Contributor

@clatapie clatapie commented Feb 8, 2023

After a discussion with @jorgepiloto, the way to fix it seems to impose Sphinx==5.3.0 and ansys-sphinx-theme==0.8.2.

@clatapie clatapie self-assigned this Feb 8, 2023
@clatapie clatapie linked an issue Feb 8, 2023 that may be closed by this pull request
@github-actions github-actions bot added Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc) labels Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #1850 (a329b08) into main (4120283) will decrease coverage by 5.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
- Coverage   85.90%   80.90%   -5.00%     
==========================================
  Files          44       44              
  Lines        7840     7840              
==========================================
- Hits         6735     6343     -392     
- Misses       1105     1497     +392     

@clatapie clatapie merged commit a684c94 into main Feb 8, 2023
@clatapie clatapie deleted the bug/doc-switcher branch February 8, 2023 14:34
@germa89
Copy link
Collaborator

germa89 commented Feb 20, 2023

What was the issue here?

@RobPasMue
Copy link
Member

The new ansys-sphinx-theme version is not yet compatible with Sphinx 6>=. So, updating the ansys-sphinx-theme implies going back to 5.3.0. There are incompatibility issues with the pydata-theme we are extending on our own theme.

@germa89
Copy link
Collaborator

germa89 commented Feb 20, 2023

I see... Thank you Robert!

@RobPasMue
Copy link
Member

FYI - once we are compatible with Sphinx 6>= we will let people now =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with the documentation switcher
3 participants