-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error reporting when connnecting with a bad channel #1859
Conversation
Please add one of the following labels to add this contribution to the Release Notes 👇 |
Codecov Report
@@ Coverage Diff @@
## main #1859 +/- ##
==========================================
- Coverage 85.72% 80.93% -4.80%
==========================================
Files 44 44
Lines 7840 7842 +2
==========================================
- Hits 6721 6347 -374
- Misses 1119 1495 +376 |
7dad2b1
to
0f7d850
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @plule-ansys !!
I happily approve. I just have some questions regarding implementation. Regards!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @germa89's comments. Apart from that, it looks good to me. 👍
Thank you @plule-ansys!
Merged. Thank you @plule-ansys !! :) |
Connecting PyMAPDL to a bad channel leads to an exception cascade instead of reporting the actual failure:
Similarly, a bad channel with an interceptor also leads to an exception cascade:
This pull request adds a check of the presence of a PID before trying to get a status from it, and improves the
_channel_str
method to try to find nested targets. For both example, the error is now the expected: