Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting the number of scalars values for colour in aplot. #1865

Merged
merged 4 commits into from
Feb 20, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 20, 2023

The mapdl.aplot seems to give errors from time to time because it tries to allocate a huge array for area colouring.

In this PR we limite the number of colours to be 256. The array size is still the same (number of areas), but now we use an ints instead of floats.

Close #1691 and #1791

@germa89 germa89 added the BUG Issue, problem or error in PyMAPDL label Feb 20, 2023
@germa89 germa89 self-assigned this Feb 20, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Feb 20, 2023

Pinging @akaszynski because the initial implementation was made by him. So I rather have his approval.

Pinging @AlejandroFernandezLuces as future Alex Pyvista-PyMAPDL reviewer.

Pinging @clatapie as PyMAPDL reviewer

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and this makes more sense. Thanks @germa89.

@akaszynski akaszynski merged commit 3457cb5 into main Feb 20, 2023
@akaszynski akaszynski deleted the fix/aplot-coloring-issue branch February 20, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants