Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding python cli application example #1869

Merged
merged 18 commits into from
Feb 22, 2023
Merged

Adding python cli application example #1869

merged 18 commits into from
Feb 22, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 21, 2023 •
edited

As the title.

Close #1871

@github-actions github-actions bot added Documentation Documentation related (improving, adding, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Feb 21, 2023
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@germa89
Copy link
Collaborator Author

germa89 commented Feb 21, 2023

Preview of the page:

image

@germa89
Copy link
Collaborator Author

germa89 commented Feb 21, 2023

DO NOT MERGE until @PipKat gives the OK. :)

PipKat
PipKat approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of these edits are based on Google style guidelines.

@germa89
Copy link
Collaborator Author

germa89 commented Feb 22, 2023

Lots of these edits are based on Google style guidelines.

Definitely I should have a look at those.... #ThankYouLots

germa89 and others added 2 commits February 22, 2023 11:59
@germa89 @PipKat
Apply suggestions from Kathy code review
820b63a 
Thank you Kathy!

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@germa89
Remove watermark file
c6a5515
@codecov
Copy link

codecov bot commented Feb 22, 2023 •
edited

Codecov Report

Merging #1869 (6e08d45) into main (a4b3242) will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1869      +/-   ##
==========================================
+ Coverage   85.70%   85.86%   +0.15%     
==========================================
  Files          44       44              
  Lines        7842     7844       +2     
==========================================
+ Hits         6721     6735      +14     
+ Misses       1121     1109      -12

@germa89
Copy link
Collaborator Author

germa89 commented Feb 22, 2023

Still nothing... we need Sphinx 6.0 or higher. ansys-sphinx-theme does not support it yet. #Waiting.

@germa89
Copy link
Collaborator Author

germa89 commented Feb 22, 2023

Still nothing... we need Sphinx 6.0 or higher. ansys-sphinx-theme does not support it yet. #Waiting.

@germa89 germa89 merged commit 39e9f62 into main Feb 22, 2023
@germa89 germa89 deleted the feat/adding-python-cli-example branch February 22, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat approved these changes

@akaszynski akaszynski Awaiting requested review from akaszynski

Assignees
No one assigned
Labels
Documentation Documentation related (improving, adding, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Python CLI Example
2 participants
@germa89 @PipKat