Passing plotter not requiring return_plotter #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germa89
added
Enhancement
|
Please add one of the following labels to add this contribution to the Release Notes 👇 |
Codecov Report
@@ Coverage Diff @@
## main #1875 +/- ##
==========================================
- Coverage 85.79% 85.78% -0.02%
==========================================
Files 44 44
Lines 7844 7844
==========================================
- Hits 6730 6729 -1
- Misses 1114 1115 +1 |
germa89
deleted the
feat/passing-plotter-not-requiring-return_plotter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title. It allows us to get rid of
return_plotterspecification when usingplotter.Close #1825