Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increasing timeout #1880

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Increasing timeout #1880

merged 1 commit into from
Feb 23, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 23, 2023

Close #1879

Pinging @rajesh1359

@germa89 germa89 added the Enhancement Improve any current implemented feature label Feb 23, 2023
@germa89 germa89 self-assigned this Feb 23, 2023
@github-actions github-actions bot added Documentation Documentation related (improving, adding, etc) New Feature Request or proposal for a new feature labels Feb 23, 2023
rajesh1359
rajesh1359 approved these changes Feb 23, 2023
View reviewed changes
Copy link

@rajesh1359 rajesh1359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @germa89. Looks good.

@codecov
Copy link

codecov bot commented Feb 23, 2023 •
edited

Codecov Report

Merging #1880 (83b9cf5) into main (a5e46bc) will increase coverage by 3.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1880      +/-   ##
==========================================
+ Coverage   82.53%   85.86%   +3.32%     
==========================================
  Files          44       44              
  Lines        7844     7844              
==========================================
+ Hits         6474     6735     +261     
+ Misses       1370     1109     -261

@germa89
Copy link
Collaborator Author

germa89 commented Feb 23, 2023

LGTM

@germa89 germa89 enabled auto-merge (squash) February 23, 2023 07:17
pyansys-ci-bot
pyansys-ci-bot approved these changes Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so 😬

@germa89 germa89 merged commit bbaa7e7 into main Feb 23, 2023
@germa89 germa89 deleted the feat/increasing-timeout branch February 23, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajesh1359 rajesh1359 rajesh1359 approved these changes

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

Assignees

@germa89 germa89

Labels
Documentation Documentation related (improving, adding, etc) Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase the start_timeout in launch_mapdl function
3 participants
@germa89 @rajesh1359 @pyansys-ci-bot