Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ISSUE_TEMPLATE folder #1888

Merged
merged 8 commits into from
Mar 13, 2023
Merged

Update ISSUE_TEMPLATE folder #1888

merged 8 commits into from
Mar 13, 2023

Conversation

clatapie
Copy link
Contributor

Closes #1887.

@clatapie clatapie self-assigned this Feb 24, 2023
@clatapie clatapie linked an issue Feb 24, 2023 that may be closed by this pull request
Removal of ISSUE_TEMPLATE #1887
Closed
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) labels Feb 24, 2023
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@clatapie clatapie enabled auto-merge (squash) February 24, 2023 10:51
@RobPasMue
Copy link
Member

Jeez. This workflow fails a lot...

@clatapie
Copy link
Contributor Author

Yes, there are some issues going on regarding the Unit Tests.

@germa89
Copy link
Collaborator

germa89 commented Feb 26, 2023

Jeez. This workflow fails a lot...

Tell me about it xD

@germa89
Copy link
Collaborator

germa89 commented Feb 26, 2023

I'm personally against this PR. Our bug template is more complete and specific. I prefer it to the default one.

See:
#1887 (comment)

@RobPasMue
Copy link
Member

I'm personally against this PR. Our bug template is more complete and specific. I prefer it to the default one.

See: #1887 (comment)

Let's iterate on the issue before doing anything else

@clatapie clatapie changed the title Remove ISSUE_TEMPLATE folder Update ISSUE_TEMPLATE folder Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023 •
edited

Codecov Report

Merging #1888 (84f3374) into main (f1df1c1) will increase coverage by 4.93%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1888      +/-   ##
==========================================
+ Coverage   80.94%   85.88%   +4.93%     
==========================================
  Files          44       44              
  Lines        7857     7857              
==========================================
+ Hits         6360     6748     +388     
+ Misses       1497     1109     -388

@germa89
Copy link
Collaborator

germa89 commented Mar 2, 2023

LGTM.

pyansys-ci-bot
pyansys-ci-bot approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so 😬

@germa89 germa89 mentioned this pull request Mar 2, 2023
Closed
@clatapie clatapie merged commit 39e907d into main Mar 13, 2023
@clatapie clatapie deleted the maint/remove_issue_template branch March 13, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@germa89 germa89 Awaiting requested review from germa89

Assignees

@clatapie clatapie

Labels
CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removal of ISSUE_TEMPLATE
4 participants
@clatapie @RobPasMue @germa89 @pyansys-ci-bot