Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs fixes #1897

Merged
merged 3 commits into from
Mar 1, 2023
Merged

Docs fixes #1897

merged 3 commits into from
Mar 1, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 1, 2023 •
edited

  • Fix dpf inventory problem
  • Fix contributing issue
  • Fixing vale warning

Close #1895

@github-actions github-actions bot added Documentation Documentation related (improving, adding, etc) BUG Issue, problem or error in PyMAPDL labels Mar 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Mar 1, 2023 •
edited

Codecov Report

Merging #1897 (bf7867f) into main (89da3a4) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1897      +/-   ##
==========================================
+ Coverage   85.72%   85.83%   +0.11%     
==========================================
  Files          44       44              
  Lines        7853     7853              
==========================================
+ Hits         6732     6741       +9     
+ Misses       1121     1112       -9

@germa89
Copy link
Collaborator Author

germa89 commented Mar 1, 2023

LGTM

pyansys-ci-bot
pyansys-ci-bot approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so 😬

@germa89 germa89 enabled auto-merge (squash) March 1, 2023 08:06
@germa89 germa89 merged commit ada9eb0 into main Mar 1, 2023
@germa89 germa89 deleted the fix/dpf-docs-inventory branch March 1, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

Assignees
No one assigned
Labels
BUG Issue, problem or error in PyMAPDL Documentation Documentation related (improving, adding, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contribute link broken
2 participants
@germa89 @pyansys-ci-bot