Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raising warning if lenght of string is GT 32 chars #1911

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 13, 2023

As the title.

@germa89 germa89 requested a review from clatapie March 13, 2023 08:11
@germa89 germa89 self-assigned this Mar 13, 2023
@github-actions github-actions bot added the BUG Issue, problem or error in PyMAPDL label Mar 13, 2023
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #1911 (0658467) into main (f1df1c1) will increase coverage by 4.98%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1911      +/-   ##
==========================================
+ Coverage   80.94%   85.92%   +4.98%     
==========================================
  Files          44       44              
  Lines        7857     7859       +2     
==========================================
+ Hits         6360     6753     +393     
+ Misses       1497     1106     -391     

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit a868f71 into main Mar 14, 2023
@germa89 germa89 deleted the fix/raise-warning-if-string-is-longer-than-32-chars branch March 14, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants