Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homogenising error handling #1923

Merged
merged 4 commits into from
Mar 14, 2023
Merged

Homogenising error handling #1923

merged 4 commits into from
Mar 14, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 14, 2023

As the title.

Use the same functions/methods for error handling.

This has been taken from #1912

@germa89 germa89 added the Enhancement Improve any current implemented feature label Mar 14, 2023
@germa89 germa89 requested a review from clatapie March 14, 2023 10:52
@germa89 germa89 self-assigned this Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #1923 (0e6ff4f) into main (b5b02f4) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1923      +/-   ##
==========================================
- Coverage   85.83%   85.77%   -0.06%     
==========================================
  Files          44       44              
  Lines        7870     7875       +5     
==========================================
  Hits         6755     6755              
- Misses       1115     1120       +5     

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

tests/test_errors.py Show resolved Hide resolved
Co-authored-by: Camille <78221213+clatapie@users.noreply.github.com>
@germa89 germa89 merged commit 58c85ad into main Mar 14, 2023
@germa89 germa89 deleted the feat/improving-error-handling branch March 14, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants