Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding RUNNING_TESTS global flag. #1937

Merged
merged 13 commits into from
Mar 24, 2023
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 23, 2023

Implementing global "RUNING_TEST" flags and the corresponding context manager.

Improving examples coverage.

@germa89
Copy link
Collaborator Author

germa89 commented Mar 23, 2023

I created this branch from a previous one based on #1931 .. so this should be merged after that one.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #1937 (02a27a8) into main (592a8d3) will decrease coverage by 3.04%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main    #1937      +/-   ##
==========================================
- Coverage   85.75%   82.72%   -3.04%     
==========================================
  Files          44       44              
  Lines        7878     7888      +10     
==========================================
- Hits         6756     6525     -231     
- Misses       1122     1363     +241     

@germa89 germa89 enabled auto-merge (squash) March 23, 2023 10:41
@germa89 germa89 requested review from a team and clatapie and removed request for a team March 23, 2023 16:12
@germa89 germa89 self-assigned this Mar 23, 2023
@germa89 germa89 added the Enhancement Improve any current implemented feature label Mar 23, 2023
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@germa89 germa89 merged commit 71881b5 into main Mar 24, 2023
@germa89 germa89 deleted the feat/testing-examples-download branch March 24, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants