Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pytest options to envvar and runtime error replacement #1953

Merged
merged 9 commits into from
Apr 4, 2023
Merged

Pytest options to envvar and runtime error replacement #1953

merged 9 commits into from
Apr 4, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 30, 2023

Some small fixes

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) labels Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023 •
edited

Codecov Report

Merging #1953 (1a13131) into main (687e761) will decrease coverage by 4.99%.
The diff coverage is 35.71%.

@@            Coverage Diff             @@
##             main    #1953      +/-   ##
==========================================
- Coverage   85.99%   81.00%   -4.99%     
==========================================
  Files          44       44              
  Lines        7877     7914      +37     
==========================================
- Hits         6774     6411     -363     
- Misses       1103     1503     +400

@germa89 germa89 requested a review from clatapie April 3, 2023 11:10
clatapie
clatapie reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some lines raising a MapdlRuntimeError are not covered by the tests. Is it something you want to change or do you want to keep it that way?

@germa89
Copy link
Collaborator Author

germa89 commented Apr 3, 2023

Some lines raising a MapdlRuntimeError are not covered by the tests. Is it something you want to change or do you want to keep it that way?

I think increasing the coverage will mean to work in functionalities, instead of the purpose of the PR which is error handling.

@germa89 germa89 requested a review from clatapie April 3, 2023 17:17
clatapie
clatapie approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@germa89 germa89 merged commit e395fbc into main Apr 4, 2023
25 of 27 checks passed
@germa89 germa89 deleted the ci/clarify-pytest-options branch April 4, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clatapie clatapie clatapie approved these changes

Assignees
No one assigned
Labels
CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@germa89 @clatapie